UFO: Alien Invasion Issue Tracker
UFO: Alien Invasion
Go to the previous open issue
Go to the previous issue (open or closed)
star_faded.png
Please log in to bookmark issues
icon_project.png UFO: Alien Invasion / Closed Bug report #3353 Long msgids not translated
Go to the next issue (open or closed)
Go to the next open issue
This issue has been closed with status "Closed" and resolution "Not determined".
Issue basics
  • Type of issue
    Bug report
  • Category
    Story and Text
  • Targetted for
    Not determined
  • Status
    Closed
  • Priority
    4. Useful
User pain
  • Type of bug
    Not triaged
  • Likelihood
    Not triaged
  • Effect
    Not triaged
Affected by this issue (0)
There are no items
People involved
Times and dates
  • Posted at
  • Last updated
  • Estimated time
    Not estimated
Issue details
  • Resolution
    Not determined
  • Reproducability
    Not determined
  • Severity
    Not determined
  • Complexity
    Not determined
  • Platform
    Not determined
  • Architecture
    Not determined
Attachments (0)
There is nothing attached to this issue
Duplicate issues (0)
This issue does not have any duplicates
Description
[http://sourceforge.net/p/ufoai/bugs/3353 Item 3353] imported from sourceforge.net tracker on 2013-01-28 20:08:16

The msgids defined in .ufo files are not translated, despite having updated the .po file and compiled the language files, the log shows that translations can't be found even for english, I also noticed that several of the long msgids in the po are missing the last character (for example: ending in "Cdr. Navarr"), except the one for the medium alien armour (alien_medium_armour_txt) which is cut at the first double quote inside the msgid, script error?
===== Comments Ported from Sourceforge =====

====== darkrainx (2012-08-16 01:00:38) ======


====== darkrainx (2012-08-17 03:59:24) ======

Progress has definitely been made but there are still issues, after comparing the log from the most recent master with my newly updated ufoai-es.po I found:

1.) msgids that are cut at the first double quote ("):
craft_electronics_raven_txt
craft_weapon_sparrowhawk_txt
craft_ammo_sparrowhawk_txt
^^ these appear as a single "Technical Specifications:" msgid in the .po
alien_medium_armour_txt
^^ this is more notorious because it shows as a partial sentence
this is odd as I found other msgids with double quotes that are fine...

2.) msgids that are missing form the .po, but present in the .ufo:
hovernet_autopsy_txt
hovernet_adv_autopsy_txt
news_phalanx_and_mumbai_aftermath_txt
^ the last one starts with a double quote so it might be cut at the very start, but the first two don't

3.) finally, msgids that seem to be correct in the .po but the log still states no translation was found for:
inter_stiletto_txt
ortnok_autopsy_txt
taman_autopsy_txt
taman_autopsy_extra_txt
shevaar_autopsy_txt
combat_armour_txt
news_after_the_war_txt
enemy_on_earth_txt
orbital_ufo_activity_txt
pistol_txt
rpg_txt
grenl_txt
medikit_txt
sniper_txt

I'm not including any empty msgids (those with only "_") nor untraslated/fuzzy entries in the list
====== tlh2000 (2012-08-17 05:53:22) ======

the checked texts look ok in the pot file. did you sync against the pot file? or ran make update-po?
====== darkrainx (2012-08-17 19:28:45.046000) ======

Yes I did sync against the pot file, check these:
http://ufoai.git.sourceforge.net/git/gitweb.cgi?p=ufoai/ufoai;a=blob;f=src/po/ufoai.pot;hb=HEAD#l5817
^^ The medium alien armour msgid
http://ufoai.git.sourceforge.net/git/gitweb.cgi?p=ufoai/ufoai;a=blob;f=src/po/ufoai.pot;hb=HEAD#l3935
^^ Can't prove it but I'm pretty sure this is for the Raven ECM and Sparrowhawk Missiles that are otherwise missing.
That's for group one, as for group two I don't have a link because they are, well, missing, but you'll have to trust me on this, those three msgids are no where to be found in the pot -at least not the one in the repo-, and for group three well that's what puzzles me about them, they seem to be OK in the po/pot and translated as well (I pushed the updated ufoai-es.po) but the game won't see them - see the newly attached log

PS I don't if those links will keep working with the sourceforge upgrade
====== darkrainx (2012-08-27 23:57:54.911000) ======

As of latest master the cut and missing msgids are fixed and work fine, that only leaves the game refusing to see the following:

inter_stiletto_txt
ortnok_autopsy_txt
taman_autopsy_txt
taman_autopsy_extra_txt
shevaar_autopsy_txt
combat_armour_txt
news_after_the_war_txt
enemy_on_earth_txt
orbital_ufo_activity_txt
pistol_txt
rpg_txt
grenl_txt
medikit_txt
sniper_txt

after poking at it for a while I found that it's caused by the strings being too long, in fact increasing the size of com_token (parse.cpp) solves the problem, BUT in order to accommodate the longest text (news_after_the_war_txt) it would require to be able to hold at least 27KB
====== tlh2000 (2012-09-10 15:16:51.918000) ======

- **status**: open --> pending

====== tlh2000 (2012-09-10 15:17:12.116000) ======

should be fixed with c707580be13d49e96e27c695aeb7f65acdc3b757
====== darkrainx (2012-09-13 01:38:26.786000) ======

indeed, its been fixed.
====== aduke1 (2012-09-21 19:53:41.328000) ======

- **status**: pending --> closed
Steps to reproduce this issue
Nothing entered.
Todos (0 / 0)
Issue created
footer_logo.png The Bug Genie 4.3.1 | Support | Feedback spinning_16.gif